Implementation of Stanford Cars prototype dataset #5442

abhi-glitchhg · 2022-02-18T17:56:08Z

stanford cars prototype dataset #5336

facebook-github-bot · 2022-02-18T17:56:14Z

💊 CI failures summary and remediations

As of commit 801e9b0 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

abhi-glitchhg · 2022-02-19T06:37:59Z

I have got a problem and I am not able to fix it.
the _make_datapipe method recieves a list of IterPipe objects. There will be two objects becuase resources method return a list with two HttpResource objects.

So as per my understanding first object will be related to images(TarArchiveReaderIterDataPipe object) and second object will be related to labels and bounding boxes(FileOpenerIterDataPipe object).
And this is correct ;

images dp: <torchdata.datapipes.iter.util.tararchivereader.TarArchiveReaderIterDataPipe object at 0x7f43f5ed4910> targets dp: <torch.utils.data.datapipes.iter.fileopener.FileOpenerIterDataPipe object at 0x7f43f5ed4340>

but sometimes both the dps are related to the labels and bounding boxes;

images dp: <torch.utils.data.datapipes.iter.fileopener.FileOpenerIterDataPipe object at 0x7fd7ef58edc0> targets dp: <torch.utils.data.datapipes.iter.fileopener.FileOpenerIterDataPipe object at 0x7fd7ef5a7160>

I do not understand why this is happening?
Can anyone help me out?
Thanks

cc @pmeier

pmeier

Thanks @abhi-glitchhg for reporting this. This is a bug in our resource loading. I've send a patch in #5447 that should fix this behavior. After that is merged, you can update your branch and the issue should be gone.

I had an superficial look and so far this looks really good! I'll do another round after you mark the PR as ready for review.

torchvision/prototype/datasets/_builtin/__init__.py

torchvision/prototype/datasets/_builtin/stanford_cars.py

abhi-glitchhg · 2022-02-25T19:25:05Z

Sorry for the delay! I will try to finish this by the weekend!

…into stanfordcars

torchvision/prototype/datasets/_builtin/stanford_cars.py

pmeier

Thanks @abhi-glitchhg, we are almost done! Just a few minor comments including #5442 (comment) from a previous review left. After that we are good to merge!

test/builtin_dataset_mocks.py

pmeier

Awesome, thanks a lot for the patience @abhi-glitchhg!

pmeier · 2022-03-09T16:32:02Z

Hey @abhi-glitchhg, we appreciate your responsiveness, but you don't need to update the branch for every new commit on the main branch. We will do that before we merge. Otherwise, we would be wasting a lot of CI resources for very little gain.

One exception is if GitHub auto-detects some conflicts. In that case, feel free to address them before the final approval.

NicolasHug

Stamping, thanks @abhi-glitchhg

Summary: * basic stanford cars structure added. * added class in the init. * how to decode the images * fix typo in init * works partially * formatting * formatting * formatting * formatting * formatting * minor changes * minor changes * issue resolved * both datapipes are in sync * checksum dict keys changed * formatting * "ufmt formatting" * "ufmt formatting" * formatting * minor change * minor change * test added * lint (end of line issue) * lint (end of line issue) * minor changes * mock dataset formatting * minor changes * hopefully final * formatting * prototype test * prototype test * prototype test * prototype test * prototype test * prototype test * prototype test * prototype test * Update builtin_dataset_mocks.py * Update stanford_cars.py * Update torchvision/prototype/datasets/_builtin/stanford_cars.py * Update torchvision/prototype/datasets/_builtin/stanford_cars.py * Update torchvision/prototype/datasets/_builtin/stanford_cars.py * Update torchvision/prototype/datasets/_builtin/stanford_cars.py * formatting and cleaning * formatting and cleaning * Update torchvision/prototype/datasets/_builtin/stanford_cars.py * generate catefories script * generate categories script added * sigh * sigh * sigh * minor changes * linting Reviewed By: vmoens Differential Revision: D34879003 fbshipit-source-id: d9ffca1e9c2f5758dc0f4571f4e915fe45cb4b68 Co-authored-by: Philip Meier <github.pmeier@posteo.de> Co-authored-by: Philip Meier <github.pmeier@posteo.de> Co-authored-by: Philip Meier <github.pmeier@posteo.de> Co-authored-by: Philip Meier <github.pmeier@posteo.de> Co-authored-by: Philip Meier <github.pmeier@posteo.de> Co-authored-by: Philip Meier <github.pmeier@posteo.de> Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>

abhi-glitchhg added 3 commits February 18, 2022 23:09

basic stanford cars structure added.

72ccc5c

added class in the init.

1ce692c

how to decode the images

20794e2

pytorch-bot bot added the ciflow/default label Feb 18, 2022

facebook-github-bot added the cla signed label Feb 18, 2022

abhi-glitchhg marked this pull request as draft February 18, 2022 17:56

abhi-glitchhg and others added 6 commits February 18, 2022 23:26

Merge branch 'main' into stanfordcars

64dca37

fix typo in init

e4c3f9d

works partially

9ae5f23

formatting

d965622

formatting

eb2bc93

formatting

a4041a8

abhi-glitchhg changed the title ~~[WIP] Stanford Cars prototype dataset~~ [WIP] Implementation of Stanford Cars prototype dataset Feb 19, 2022

abhi-glitchhg added 2 commits February 19, 2022 10:43

formatting

c681d39

formatting

a3953fe

pmeier mentioned this pull request Feb 21, 2022

fix prototype resource loading #5447

Merged

pmeier reviewed Feb 21, 2022

View reviewed changes

Merge branch 'main' into stanfordcars

6774c24

pmeier added module: datasets prototype labels Feb 22, 2022

pmeier linked an issue Feb 23, 2022 that may be closed by this pull request

StanfordCars #5356

Closed

abhi-glitchhg and others added 6 commits February 26, 2022 00:55

Merge branch 'main' into stanfordcars

b9b38e8

Merge branch 'main' into stanfordcars

ae5a47b

Merge branch 'main' into stanfordcars

3e47f8e

minor changes

8bd7348

minor changes

7ad896e

issue resolved

5922e1b

abhi-glitchhg marked this pull request as draft March 7, 2022 09:04

abhi-glitchhg and others added 3 commits March 8, 2022 16:59

Merge branch 'main' into stanfordcars

d04e9d4

generate catefories script

ce73276

Merge branch 'stanfordcars' of https://github.com/abhi-glitchhg/vision …

44d91b1

…into stanfordcars

abhi-glitchhg commented Mar 8, 2022

View reviewed changes

torchvision/prototype/datasets/_builtin/stanford_cars.py Outdated Show resolved Hide resolved

generate categories script added

6248e03

pmeier reviewed Mar 8, 2022

View reviewed changes

torchvision/prototype/datasets/_builtin/stanford_cars.py Outdated Show resolved Hide resolved

torchvision/prototype/datasets/_builtin/stanford_cars.py Outdated Show resolved Hide resolved

abhi-glitchhg added 3 commits March 8, 2022 22:37

sigh

05f81a6

sigh

f4938bb

sigh

a8d88d1

abhi-glitchhg marked this pull request as ready for review March 8, 2022 17:13

abhi-glitchhg requested a review from pmeier March 8, 2022 20:22

pmeier reviewed Mar 9, 2022

View reviewed changes

test/builtin_dataset_mocks.py Outdated Show resolved Hide resolved

test/builtin_dataset_mocks.py Outdated Show resolved Hide resolved

test/builtin_dataset_mocks.py Outdated Show resolved Hide resolved

abhi-glitchhg commented Mar 9, 2022

View reviewed changes

test/builtin_dataset_mocks.py Outdated Show resolved Hide resolved

abhi-glitchhg force-pushed the stanfordcars branch from 12d422e to a8d88d1 Compare March 9, 2022 10:06

abhi-glitchhg added 2 commits March 9, 2022 15:43

minor changes

7e83969

linting

0302eb6

abhi-glitchhg requested a review from pmeier March 9, 2022 11:15

Merge branch 'main' into stanfordcars

0c409dc

pmeier approved these changes Mar 9, 2022

View reviewed changes

pmeier requested a review from NicolasHug March 9, 2022 13:16

abhi-glitchhg added 2 commits March 9, 2022 20:52

Merge branch 'main' into stanfordcars

d9f3af7

Merge branch 'main' into stanfordcars

7dc2c71

NicolasHug approved these changes Mar 10, 2022

View reviewed changes

NicolasHug and others added 2 commits March 10, 2022 08:45

Merge branch 'main' into stanfordcars

70035d1

Merge branch 'main' into stanfordcars

801e9b0

pmeier merged commit a8bde78 into pytorch:main Mar 10, 2022

abhi-glitchhg deleted the stanfordcars branch August 8, 2022 18:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implementation of Stanford Cars prototype dataset #5442

Implementation of Stanford Cars prototype dataset #5442

abhi-glitchhg commented Feb 18, 2022 •

edited

Loading

facebook-github-bot commented Feb 18, 2022 •

edited

Loading

abhi-glitchhg commented Feb 19, 2022 •

edited

Loading

pmeier left a comment •

edited

Loading

abhi-glitchhg commented Feb 25, 2022

pmeier left a comment •

edited

Loading

pmeier left a comment

pmeier commented Mar 9, 2022

NicolasHug left a comment

Implementation of Stanford Cars prototype dataset #5442

Implementation of Stanford Cars prototype dataset #5442

Conversation

abhi-glitchhg commented Feb 18, 2022 • edited Loading

facebook-github-bot commented Feb 18, 2022 • edited Loading

💊 CI failures summary and remediations

abhi-glitchhg commented Feb 19, 2022 • edited Loading

pmeier left a comment • edited Loading

Choose a reason for hiding this comment

abhi-glitchhg commented Feb 25, 2022

pmeier left a comment • edited Loading

Choose a reason for hiding this comment

pmeier left a comment

Choose a reason for hiding this comment

pmeier commented Mar 9, 2022

NicolasHug left a comment

Choose a reason for hiding this comment

abhi-glitchhg commented Feb 18, 2022 •

edited

Loading

facebook-github-bot commented Feb 18, 2022 •

edited

Loading

abhi-glitchhg commented Feb 19, 2022 •

edited

Loading

pmeier left a comment •

edited

Loading

pmeier left a comment •

edited

Loading