-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert exposing convNormActivation in ops #5472
Revert exposing convNormActivation in ops #5472
Conversation
💊 CI failures summary and remediationsAs of commit 3a7695c (more details on the Dr. CI page):
2 failures not recognized by patterns:
This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
@@ -6,7 +6,7 @@ | |||
from torch import Tensor | |||
from torch.nn.modules.batchnorm import BatchNorm2d | |||
from torch.nn.modules.instancenorm import InstanceNorm2d | |||
from torchvision.ops import ConvNormActivation | |||
from torchvision.ops.misc import ConvNormActivation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NicolasHug I added you are reviewer as this change touches the RAFT model and is meant to be cherrypicked in the v12.0 release, so I want to double check with you if you spot any problems with this?
For context on this discussion you can have a look at #5445
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be fine and we will literally undo this change immediately after introducing the Conv2dNormActivation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@@ -6,7 +6,7 @@ | |||
from torch import Tensor | |||
from torch.nn.modules.batchnorm import BatchNorm2d | |||
from torch.nn.modules.instancenorm import InstanceNorm2d | |||
from torchvision.ops import ConvNormActivation | |||
from torchvision.ops.misc import ConvNormActivation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be fine and we will literally undo this change immediately after introducing the Conv2dNormActivation
Hey @jdsgomes! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
Reviewed By: jdsgomes Differential Revision: D34475311 fbshipit-source-id: 13ea879714fd265166e42409956a73918ac0bd91
And remove references in documentation
This change will be cherrypicked for the v12.0 release