add prototype AugMix transform #5492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit 3a455d8 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
datumbox
reviewed
Feb 28, 2022
Conflicts: torchvision/prototype/transforms/_auto_augment.py torchvision/prototype/transforms/_utils.py
pmeier
commented
Feb 28, 2022
Comment on lines
+17
to
+26
| def _put_into_sample(sample: Any, id: Tuple[Any, ...], item: Any) -> Any: | ||
| if not id: | ||
| return item | ||
|
|
||
| parent = sample | ||
| for key in id[:-1]: | ||
| parent = parent[key] | ||
|
|
||
| parent[id[-1]] = item | ||
| return sample |
There was a problem hiding this comment.
Should we put it on ._utils?
There was a problem hiding this comment.
It probably should be in torchvision.utils._internal since it will be needed in torchvision.prototype.datasets. Given that we currently only need it here, I would leave it to #5422 to do this properly and remove the definition here.
datumbox
reviewed
Feb 28, 2022
Comment on lines
+17
to
+26
| def _put_into_sample(sample: Any, id: Tuple[Any, ...], item: Any) -> Any: | ||
| if not id: | ||
| return item | ||
|
|
||
| parent = sample | ||
| for key in id[:-1]: | ||
| parent = parent[key] | ||
|
|
||
| parent[id[-1]] = item | ||
| return sample |
There was a problem hiding this comment.
Should we put it on ._utils?
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 5, 2022
Summary: * add prototype AugMix transform * cleanup * refactor auto augment subclasses to only trnasform a single image * address review comments Reviewed By: datumbox Differential Revision: D34579510 fbshipit-source-id: b483642885913f844ffd72ef449de5a82467fc78
7 tasks
28 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5411 for prototype transforms.