-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Country211 prototype dataset #5506
Conversation
💊 CI failures summary and remediationsAs of commit 1fb15f7 (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages: Bandit / build (1/1)Step: "Run actions/checkout@v2" (full log | diagnosis details | 🔁 rerun)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor comments. Otherwise this already looks good @Dbhasin1!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Dbhasin1!
def _filter_split(self, data: Tuple[str, Any], *, split: str) -> bool: | ||
return pathlib.Path(data[0]).parent.parent.name == split | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is no longer needed.
def _filter_split(self, data: Tuple[str, Any], *, split: str) -> bool: | |
return pathlib.Path(data[0]).parent.parent.name == split |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stamping, thanks @Dbhasin1
Hey @NicolasHug! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
Summary: * add country211 * remove unused import * map val to valid and use path comparator * remove unused import * resolve keyerror * map split names in dataset mock Reviewed By: vmoens Differential Revision: D34878993 fbshipit-source-id: 304734d8f3a24f156eae5feeaa8b398a975c6a0a Co-authored-by: Dbhasin1 <drishti_b@me.iitr.c.in> Co-authored-by: Nicolas Hug <nicolashug@fb.com>
Fixes #5337
cc: @pmeier