Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Country211 prototype dataset #5506

Merged
merged 7 commits into from
Mar 3, 2022
Merged

Conversation

Dbhasin1
Copy link
Contributor

@Dbhasin1 Dbhasin1 commented Mar 1, 2022

Fixes #5337
cc: @pmeier

@facebook-github-bot
Copy link

facebook-github-bot commented Mar 1, 2022

💊 CI failures summary and remediations

As of commit 1fb15f7 (more details on the Dr. CI page):


  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See GitHub Actions build Bandit / build (1/1)

Step: "Run actions/checkout@v2" (full log | diagnosis details | 🔁 rerun)

2022-03-03T08:39:34.2989297Z ##[error]The process '/usr/bin/git' failed with exit code 128
2022-03-03T08:32:33.0237197Z [command]/usr/bin/git -c protocol.version=2 fetch --no-tags --prune --progress --no-recurse-submodules --depth=1 origin +14a88a9a0f54c30a01d5449ba1fc862d904eb146:refs/remotes/pull/5506/merge
2022-03-03T08:34:43.4801181Z ##[error]fatal: unable to access 'https://github.com/pytorch/vision/': Failed to connect to github.com port 443: Connection timed out
2022-03-03T08:34:43.4813189Z The process '/usr/bin/git' failed with exit code 128
2022-03-03T08:34:43.4813550Z Waiting 15 seconds before trying again
2022-03-03T08:34:58.4804394Z [command]/usr/bin/git -c protocol.version=2 fetch --no-tags --prune --progress --no-recurse-submodules --depth=1 origin +14a88a9a0f54c30a01d5449ba1fc862d904eb146:refs/remotes/pull/5506/merge
2022-03-03T08:37:08.8850181Z ##[error]fatal: unable to access 'https://github.com/pytorch/vision/': Failed to connect to github.com port 443: Connection timed out
2022-03-03T08:37:08.8857218Z The process '/usr/bin/git' failed with exit code 128
2022-03-03T08:37:08.8857535Z Waiting 15 seconds before trying again
2022-03-03T08:37:23.8916944Z [command]/usr/bin/git -c protocol.version=2 fetch --no-tags --prune --progress --no-recurse-submodules --depth=1 origin +14a88a9a0f54c30a01d5449ba1fc862d904eb146:refs/remotes/pull/5506/merge
2022-03-03T08:39:34.2920850Z ##[error]fatal: unable to access 'https://github.com/pytorch/vision/': Failed to connect to github.com port 443: Connection timed out
2022-03-03T08:39:34.2989297Z ##[error]The process '/usr/bin/git' failed with exit code 128
2022-03-03T08:39:34.3139403Z Post job cleanup.
2022-03-03T08:39:34.4892268Z [command]/usr/bin/git version
2022-03-03T08:39:34.4967041Z git version 2.35.1
2022-03-03T08:39:34.5072540Z [command]/usr/bin/git config --local --name-only --get-regexp core\.sshCommand
2022-03-03T08:39:34.5110807Z [command]/usr/bin/git submodule foreach --recursive git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :
2022-03-03T08:39:34.5404713Z [command]/usr/bin/git config --local --name-only --get-regexp http\.https\:\/\/github\.com\/\.extraheader
2022-03-03T08:39:34.5447509Z http.https://github.com/.extraheader
2022-03-03T08:39:34.5459899Z [command]/usr/bin/git config --local --unset-all http.https://github.com/.extraheader
2022-03-03T08:39:34.5503579Z [command]/usr/bin/git submodule foreach --recursive git config --local --name-only --get-regexp 'http\.https\:\/\/github\.com\/\.extraheader' && git config --local --unset-all 'http.https://github.com/.extraheader' || :
2022-03-03T08:39:34.6035295Z Cleaning up orphan processes

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments. Otherwise this already looks good @Dbhasin1!

torchvision/prototype/datasets/_builtin/country211.py Outdated Show resolved Hide resolved
torchvision/prototype/datasets/_builtin/country211.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Dbhasin1!

@pmeier pmeier requested a review from NicolasHug March 2, 2022 07:34
Comment on lines +41 to +43
def _filter_split(self, data: Tuple[str, Any], *, split: str) -> bool:
return pathlib.Path(data[0]).parent.parent.name == split

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer needed.

Suggested change
def _filter_split(self, data: Tuple[str, Any], *, split: str) -> bool:
return pathlib.Path(data[0]).parent.parent.name == split

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamping, thanks @Dbhasin1

@NicolasHug NicolasHug merged commit 01f07ee into pytorch:main Mar 3, 2022
@github-actions
Copy link

github-actions bot commented Mar 3, 2022

Hey @NicolasHug!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

facebook-github-bot pushed a commit that referenced this pull request Mar 15, 2022
Summary:
* add country211

* remove unused import

* map val to valid and use path comparator

* remove unused import

* resolve keyerror

* map split names in dataset mock

Reviewed By: vmoens

Differential Revision: D34878993

fbshipit-source-id: 304734d8f3a24f156eae5feeaa8b398a975c6a0a

Co-authored-by: Dbhasin1 <drishti_b@me.iitr.c.in>
Co-authored-by: Nicolas Hug <nicolashug@fb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Country211
4 participants