Migrate GTSRB prototype dataset

[NicolasHug]

No description provided.

[NicolasHug]

I wonder if the tests are really independent. With

pytest test/test_prototype_builtin_datasets.py -k "gtsrb-test" 

the tests are green. But when I run the entire gtsrb tests with

pytest test/test_prototype_builtin_datasets.py -k gtsrb

I'm getting

__________________________ ERROR at setup of TestCommon.test_no_vanilla_tensors[gtsrb-test] ___________________________
Traceback (most recent call last):
  File "/home/nicolashug/.miniconda3/envs/pt/lib/python3.9/site-packages/_pytest/runner.py", line 340, in from_call
    result: Optional[TResult] = func()
  File "/home/nicolashug/.miniconda3/envs/pt/lib/python3.9/site-packages/_pytest/runner.py", line 261, in <lambda>
    lambda: ihook(item=item, **kwds), when=when, reraise=reraise
  File "/home/nicolashug/.miniconda3/envs/pt/lib/python3.9/site-packages/pluggy/_hooks.py", line 265, in __call__
    return self._hookexec(self.name, self.get_hookimpls(), kwargs, firstresult)
  File "/home/nicolashug/.miniconda3/envs/pt/lib/python3.9/site-packages/pluggy/_manager.py", line 80, in _hookexec
    return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
  File "/home/nicolashug/.miniconda3/envs/pt/lib/python3.9/site-packages/pluggy/_callers.py", line 55, in _multicall
    gen.send(outcome)
  File "/home/nicolashug/.miniconda3/envs/pt/lib/python3.9/site-packages/_pytest/unraisableexception.py", line 83, in pytest_runtest_setup
    yield from unraisable_exception_runtest_hook()
  File "/home/nicolashug/.miniconda3/envs/pt/lib/python3.9/site-packages/_pytest/unraisableexception.py", line 78, in unraisable_exception_runtest_hook
    warnings.warn(pytest.PytestUnraisableExceptionWarning(msg))
pytest.PytestUnraisableExceptionWarning: Exception ignored in: <_io.FileIO [closed]>

Traceback (most recent call last):
  File "/home/nicolashug/.miniconda3/envs/pt/lib/python3.9/unittest/mock.py", line 2105, in __init__
    self.name = name
ResourceWarning: unclosed file <_io.FileIO name='/tmp/pytest-of-nicolashug/pytest-32/test_no_vanilla_tensors_gtsrb_0/gtsrb/GTSRB-Training_fixed.zip' mode='rb' closefd=True>

=============================================== short test summary info ===============================================
ERROR test/test_prototype_builtin_datasets.py::TestCommon::test_no_vanilla_tensors[gtsrb-test] - pytest.PytestUnrais...

Which suggests that the training resource is still present on the temp dir somehow.

[NicolasHug]

The test execution order seems to matter here, as CI is green. Any idea of what's going on @pmeier ?

[pmeier]

I can't reproduce, sorry.

Which suggests that the training resource is still present on the temp dir somehow.

pytest's tmp_path fixture does not remove the path after the execution. It puts the files in the system temporary directory and leaves the cleanup to the OS. Still, the error has never happened before so I'm not sure what is causing this.

[pmeier]

Minor nit, otherwise LGTM. Thanks Nicolas!