Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deactivate CelebA download #6052

Merged
merged 8 commits into from
May 20, 2022
Merged

Conversation

NicolasHug
Copy link
Member

Deactivate CelebA download as decided in #5705

@datumbox datumbox requested a review from pmeier May 19, 2022 09:20
torchvision/datasets/celeba.py Show resolved Hide resolved
torchvision/datasets/celeba.py Outdated Show resolved Hide resolved
torchvision/datasets/celeba.py Show resolved Hide resolved
torchvision/datasets/celeba.py Outdated Show resolved Hide resolved
torchvision/prototype/datasets/utils/_resource.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Nicolas!

@NicolasHug NicolasHug merged commit ac56f52 into pytorch:main May 20, 2022
facebook-github-bot pushed a commit that referenced this pull request Jun 1, 2022
Summary:
* Deactivate CelebA download

* flake8

* Do proto version

* Update torchvision/prototype/datasets/utils/_resource.py

* address review

Reviewed By: NicolasHug

Differential Revision: D36760933

fbshipit-source-id: 8efe44df2ab94c66b239199e89bbe2ecc171ed84

Co-authored-by: Philip Meier <github.pmeier@posteo.de>
Co-authored-by: Philip Meier <github.pmeier@posteo.de>
NicolasHug added a commit to NicolasHug/vision that referenced this pull request Jun 9, 2022
NicolasHug added a commit that referenced this pull request Jun 9, 2022
* Revert "Indicate Celeba download parameter is deprecated and will be removed (#6059)"

This reverts commit 49496c4.

* Revert "Deactivate CelebA download (#6052)"

This reverts commit ac56f52.
NicolasHug added a commit to NicolasHug/vision that referenced this pull request Jun 9, 2022
* Revert "Indicate Celeba download parameter is deprecated and will be removed (pytorch#6059)"

This reverts commit 49496c4.

* Revert "Deactivate CelebA download (pytorch#6052)"

This reverts commit ac56f52.
@NicolasHug NicolasHug added the revert(ed) For reverted PRs, and PRs that revert other PRs label Jun 9, 2022
datumbox pushed a commit that referenced this pull request Jun 10, 2022
* Revert "Indicate Celeba download parameter is deprecated and will be removed (#6059)"

This reverts commit 49496c4.

* Revert "Deactivate CelebA download (#6052)"

This reverts commit ac56f52.
NicolasHug added a commit to NicolasHug/vision that referenced this pull request Jun 16, 2022
Summary:
* Revert "Indicate Celeba download parameter is deprecated and will be removed (pytorch#6059)"

This reverts commit 49496c4.

* Revert "Deactivate CelebA download (pytorch#6052)"

This reverts commit ac56f52.

Differential Revision: D37212658

fbshipit-source-id: 608b722a2b96317a1daf97623679a4a1b2c1f14d
facebook-github-bot pushed a commit that referenced this pull request Jun 17, 2022
Summary:
* Revert "Indicate Celeba download parameter is deprecated and will be removed (#6059)"

This reverts commit 49496c4.

* Revert "Deactivate CelebA download (#6052)"

This reverts commit ac56f52.

Reviewed By: datumbox

Differential Revision: D37212658

fbshipit-source-id: 756061b60ed3954b7ff4422b0413ec0ed6a4e932
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cla signed module: datasets revert(ed) For reverted PRs, and PRs that revert other PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants