-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deactivate CelebA download #6052
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmeier
reviewed
May 20, 2022
Co-authored-by: Philip Meier <github.pmeier@posteo.de>
pmeier
approved these changes
May 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Nicolas!
This was referenced May 20, 2022
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 1, 2022
Summary: * Deactivate CelebA download * flake8 * Do proto version * Update torchvision/prototype/datasets/utils/_resource.py * address review Reviewed By: NicolasHug Differential Revision: D36760933 fbshipit-source-id: 8efe44df2ab94c66b239199e89bbe2ecc171ed84 Co-authored-by: Philip Meier <github.pmeier@posteo.de> Co-authored-by: Philip Meier <github.pmeier@posteo.de>
NicolasHug
added a commit
to NicolasHug/vision
that referenced
this pull request
Jun 9, 2022
This reverts commit ac56f52.
NicolasHug
added a commit
that referenced
this pull request
Jun 9, 2022
NicolasHug
added a commit
to NicolasHug/vision
that referenced
this pull request
Jun 9, 2022
* Revert "Indicate Celeba download parameter is deprecated and will be removed (pytorch#6059)" This reverts commit 49496c4. * Revert "Deactivate CelebA download (pytorch#6052)" This reverts commit ac56f52.
datumbox
pushed a commit
that referenced
this pull request
Jun 10, 2022
NicolasHug
added a commit
to NicolasHug/vision
that referenced
this pull request
Jun 16, 2022
Summary: * Revert "Indicate Celeba download parameter is deprecated and will be removed (pytorch#6059)" This reverts commit 49496c4. * Revert "Deactivate CelebA download (pytorch#6052)" This reverts commit ac56f52. Differential Revision: D37212658 fbshipit-source-id: 608b722a2b96317a1daf97623679a4a1b2c1f14d
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 17, 2022
Summary: * Revert "Indicate Celeba download parameter is deprecated and will be removed (#6059)" This reverts commit 49496c4. * Revert "Deactivate CelebA download (#6052)" This reverts commit ac56f52. Reviewed By: datumbox Differential Revision: D37212658 fbshipit-source-id: 756061b60ed3954b7ff4422b0413ec0ed6a4e932
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deactivate CelebA download as decided in #5705