Expand prototype transforms consistency tests to most random tests #6522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vfdev-5
reviewed
Aug 30, 2022
| @@ -389,7 +389,7 @@ def _get_params(self, sample: Any) -> Dict[str, Any]: | |||
| shear_y = float(torch.empty(1).uniform_(self.shear[2], self.shear[3]).item()) | |||
|
|
|||
| shear = (shear_x, shear_y) | |||
| return dict(angle=angle, translations=translations, scale=scale, shear=shear) | |||
| return dict(angle=angle, translate=translate, scale=scale, shear=shear) | |||
There was a problem hiding this comment.
Nice catch! Seems like I just copied the name from stable RandomAffine.get_params but unfortunately previous tests didn't revealed that.
vfdev-5
approved these changes
Aug 30, 2022
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 9, 2022
… tests (#6522) Summary: * add checks for pure random apply transformations * add tests for some non-deterministic transforms used in classification reference * add consistency checks for most transforms * fix RandomAffine, RandomPerspective, and GaussianBlur * fix tests Reviewed By: YosuaMichael Differential Revision: D39381959 fbshipit-source-id: 8b574a1e52027fccfc079da7b7691890c560c900
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #6516. Fortunately, we didn't touch the random parameter generation during porting and so setting the random seed if sufficient for most transformations. The only ones left are the AA transforms, for which @vfdev-5 is adding checks in #6519.
Apart from the tests, this PR also fixes some bugs in
RandomAffine,RandomPerspective, andGaussianBlur.