-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[proto] Small optimization for gaussian_blur functional op #6762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vfdev-5
changed the title
[WIP] Use softmax in _get_gaussian_kernel1d
[proto] Optimize gaussian_blur functional op
Oct 17, 2022
vfdev-5
force-pushed
the
update-gaussian-blur
branch
from
October 17, 2022 09:17
b8e4e60
to
c26baa9
Compare
vfdev-5
changed the title
[proto] Optimize gaussian_blur functional op
[proto] Small optimization for gaussian_blur functional op
Oct 17, 2022
pmeier
reviewed
Oct 17, 2022
pmeier
approved these changes
Oct 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if CI is green!
Hey @vfdev-5! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 21, 2022
…6762) Summary: * Use softmax in _get_gaussian_kernel1d * Revert "Use softmax in _get_gaussian_kernel1d" This reverts commit eb8fba3. * Code update * Relaxed tolerance in consistency tests for GaussianBlur and ElasticTransform * Code review updates * Update test_prototype_transforms_consistency.py Reviewed By: YosuaMichael Differential Revision: D40588166 fbshipit-source-id: 51e0f651843efbc9487543ad889d6f6d390a19db
31 tasks
5 tasks
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Code source
This PR may also help with flaky gaussian blur tests.
Context:
Gaussian blur eager vs jit tests are flaky for uint8 input. This may be due to the fact that we cast to float32, perform the opertation in float32 and cast back to uint8. We generate conv kernels (created using exp op) in float32 and maybe accumulating precision errors.
Refs: #6755