assume that integer images are [0, 255] in equalize #6859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmeier
commented
Oct 28, 2022
| output_dtype = image.dtype | ||
| image = convert_dtype_image_tensor(image, torch.uint8) | ||
| if image.is_floating_point(): |
There was a problem hiding this comment.
We don't need to do anything for the other integers here since we assume they are already in the range [0, 255] and thus no conversion is needed.
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 31, 2022
Reviewed By: datumbox Differential Revision: D40851027 fbshipit-source-id: c3e55e63bd176e3e88501139a1a0400304a477f8
pmeier
added a commit
that referenced
this pull request
Nov 3, 2022
* fix prototype kernels * fix stable kernels * fix tests * make test more robust * improve invert for signed integers * improve invert * fix posterize * Revert "assume that integer images are [0, 255] in equalize (#6859)" This reverts commit 436ff9a. * fix solarize in AA * fix resize * Revert "fix resize" This reverts commit 5f33f4a. * add comment to float max value Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 4, 2022
Summary: * fix prototype kernels * fix stable kernels * fix tests * make test more robust * improve invert for signed integers * improve invert * fix posterize * Revert "assume that integer images are [0, 255] in equalize (#6859)" This reverts commit 436ff9a. * fix solarize in AA * fix resize * Revert "fix resize" This reverts commit 5f33f4a. * add comment to float max value Reviewed By: datumbox Differential Revision: D41020539 fbshipit-source-id: 1c618ead36a0ae4d93b4ebf07186fd39bd85d915 Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #6847 (comment), but as a follow-up to #6851.
cc @vfdev-5 @datumbox @bjuncek