-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[prototype] Gaussian Blur clean up #6888
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK to me. I'm not sure why we can't use _cast_squeeze_in
, _cast_squeeze_out
anymore, but ok.
@vfdev-5 We could use it. But this means we will have multiple pieces of code handling reshaping (or |
It seems that this closed the gap between V1 and V2 for the GaussianBlur transform. My new benchmarks between V1+pure tensor and V2+feature report:
@vfdev-5 Might be worth rerunning the benchmarks later on your side to confirm. |
Summary: * Refactor gaussian_blur * Add conditional reshape * Further refactoring * Remove unused import. Reviewed By: datumbox Differential Revision: D41020542 fbshipit-source-id: 72694024272d91818c4154f7b5f7097e6d21154f
Related to #6818
This PR:
gaussian_blur
kernelNo regression on the speed, just a small 5% improvement on CUDA:
cc @vfdev-5 @bjuncek @pmeier