Skip to content

[proto][tests] Fix missing extra_dims in make_bounding_box_loader, cxcywh #6906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pmeier merged 1 commit into from
Nov 4, 2022
Merged

[proto][tests] Fix missing extra_dims in make_bounding_box_loader, cxcywh #6906

pmeier merged 1 commit into from
Nov 4, 2022

Conversation

@vfdev-5
Copy link
Contributor

@vfdev-5 vfdev-5 commented Nov 4, 2022 •
edited by pytorch-bot bot
Loading

@vfdev-5 vfdev-5 requested a review from pmeier November 4, 2022 09:03
@vfdev-5 vfdev-5 changed the title [proto][tests] Fix missing extra_dims in cxcywh [proto][tests] Fix missing extra_dims in make_bounding_box_loader, cxcywh Nov 4, 2022
pmeier
pmeier approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Victor!

@pmeier
Copy link
Contributor

pmeier commented Nov 4, 2022

Failures are unrelated:

FAILED test/test_prototype_transforms_consistency.py::test_call_consistency[ElasticTransform-60] - AssertionError: Tensor image consistency check failed with: 

Tensor-likes are not close!

Mismatched elements: 1 / 318828 (0.0%)
Greatest absolute difference: 255 at index (2, 1, 48, 105) (up to 1 allowed)
Greatest relative difference: inf at index (2, 1, 48, 105) (up to 0.1 allowed)

@pmeier pmeier merged commit 4508c84 into main Nov 4, 2022
@pmeier pmeier deleted the vfdev-5-patch-1 branch November 4, 2022 09:32
@github-actions
Copy link

github-actions bot commented Nov 4, 2022

Hey @pmeier!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

facebook-github-bot pushed a commit that referenced this pull request Nov 14, 2022
@facebook-github-bot
[fbsync] [proto][tests] Fix missing extra_dims in cxcywh (#6906)
510c37f 
Reviewed By: NicolasHug

Differential Revision: D41265193

fbshipit-source-id: c45f01314fd9ee439250a45ba00e69579335721f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@pmeier pmeier pmeier approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug cla signed module: tests prototype

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vfdev-5 @pmeier @facebook-github-bot