Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[proto][ci] Try add GPU ci for prototype transforms #6919

Merged
merged 10 commits into from
Dec 9, 2022

Conversation

vfdev-5
Copy link
Collaborator

@vfdev-5 vfdev-5 commented Nov 7, 2022

Another attempt to enable tests on GPU for prototype transforms, based on https://github.com/pytorch/vision/blob/main/.github/workflows/test-linux-gpu.yml

Previous attempt: #6665

cc @pmeier @seemethere @bjuncek

@vfdev-5 vfdev-5 marked this pull request as draft November 7, 2022 10:41
@vfdev-5 vfdev-5 force-pushed the prototype-test-linux-gpu branch from 38f2e17 to d826dd0 Compare November 7, 2022 11:08
@vfdev-5 vfdev-5 force-pushed the prototype-test-linux-gpu branch from d826dd0 to ad9ee3a Compare November 7, 2022 11:23
@vfdev-5 vfdev-5 mentioned this pull request Nov 7, 2022
@vfdev-5 vfdev-5 marked this pull request as ready for review December 8, 2022 12:16
@vfdev-5 vfdev-5 requested a review from osalpekar December 8, 2022 12:17
@vfdev-5
Copy link
Collaborator Author

vfdev-5 commented Dec 8, 2022

@osalpekar I made updates you mentioned in #6957 (comment) and seems like this solves CUDA problem. Please review this PR and we can merge it to enable CUDA tests.

Copy link
Member

@osalpekar osalpekar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@vfdev-5 vfdev-5 merged commit 677fc93 into main Dec 9, 2022
@vfdev-5 vfdev-5 deleted the prototype-test-linux-gpu branch December 9, 2022 12:31
@github-actions
Copy link

github-actions bot commented Dec 9, 2022

Hey @vfdev-5!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

facebook-github-bot pushed a commit that referenced this pull request Dec 16, 2022
Summary:
* Try add GPU ci for prototype transforms

* Update prototype-transforms-tests-linux-gpu.yml

* Update prototype-transforms-tests-linux-gpu.yml

* Update prototype-transforms-tests-linux-gpu.yml

* Update prototype-transforms-tests-linux-gpu.yml

* Update prototype-transforms-tests-linux-gpu.yml

* add small tolerance for adjust_contrast on CUDA

* [skip-ci] update

Reviewed By: YosuaMichael

Differential Revision: D42046597

fbshipit-source-id: a90c74df96d581f510987aaddb419c3a0687e203

Co-authored-by: Philip Meier <github.pmeier@posteo.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants