Replace getbands() with get_image_num_channels()
#6941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 14, 2022
Reviewed By: NicolasHug Differential Revision: D41265203 fbshipit-source-id: 082a28ef8f8809e313c2ecf014ea156c943adb92
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Though the support of
accimageis somehow in limbo, we've previously (see #5545) fixed issues related to estimating the number of channels by removing the hardcodedgetbands()call.While scanning the codebase for improvements for Transforms V2, I noticed that the stable methods
to_tensor()andpil_to_tensor()had still two cases where they estimated the channels directly fromgetbands(). This PR replaces those two calls withget_image_num_channels()which is able to handle the various PIL variants.cc @vfdev-5