-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
skip CPU tests on GPU GHA jobs #6970
Conversation
Installation of
|
Looking at the collected env, it seems there is an issue with the CUDA setup.
The important bits:
It seems we install the right versions, but CUDA is not available for some reason. Maybe the driver is not set up properly? |
Ok, running
gives
This has nothing to do with |
@@ -13,11 +13,11 @@ | |||
import __main__ # noqa: 401 | |||
|
|||
|
|||
IN_CIRCLE_CI = os.getenv("CIRCLECI", False) == "true" | |||
IN_OSS_CI = any(os.getenv(var) == "true" for var in ["CIRCLECI", "GITHUB_ACTIONS"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One common convention for CI providers is to set the CI=true
environment variable. We could use that here as well, but I have no idea if that interferes with Meta internal systems. Thus, to be safe, we are explicit about the CI providers here. Given that we probably don't change them that often, I think this should be fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @pmeier ! LGTM as long as it does what we want :)
PR: https://github.com/pytorch/vision/actions/runs/4135402074/jobs/7147802842#step:10:35257
So roughly 6x speed-up (4x if look at the overall workflow not just the tests) |
Hey @pmeier! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
Reviewed By: vmoens Differential Revision: D44416269 fbshipit-source-id: ebffe7b7a447b70b1495cb1a614f7780219abd96
Blocked by #6957. I've debugged why no GPU test is run until 1a2efbe. Please discard my commits and comments before that.
To save CI resources, we don't run CPU tests on GPU machines. This behavior is hardcoded to CircleCI:
vision/test/conftest.py
Lines 15 to 24 in 4a310f2
With the recent push to GHA (Nova), we also need this behavior there. The environment variable is called
GITHUB_ACTIONS
and is set to"true"
in case we are in a GHA runner. This is the same as theCIRCLECI
variable that we already handled before.cc @seemethere