Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin python version for cmake workflows #7060

Merged
merged 6 commits into from
Jan 10, 2023
Merged

Conversation

pmeier
Copy link
Contributor

@pmeier pmeier commented Jan 4, 2023

On macOS, we are downloading Miniconda with

curl -o conda.sh https://repo.anaconda.com/miniconda/Miniconda3-latest-MacOSX-x86_64.sh

Until late Dec 2022 this included Python 3.9. From then on, the included Python version was 3.10 and our workflows started failing due to some unsatisfiable requirements.

Closes #7073

@pmeier pmeier changed the title pin python version for macos cmake pin python version for cmake workflows Jan 4, 2023
@pmeier pmeier marked this pull request as ready for review January 4, 2023 11:54
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @pmeier !

LGTM although LMK what you think on my comment below. I'll approve regardless so feel free to merge once you're happy with the solution

.circleci/config.yml.in Outdated Show resolved Hide resolved
@pmeier pmeier marked this pull request as draft January 10, 2023 15:41
@pmeier
Copy link
Contributor Author

pmeier commented Jan 10, 2023

On Windows we are simply using the Python that is installed on the image, which is 3.7: https://app.circleci.com/pipelines/github/pytorch/vision/22531/workflows/dc22a930-661b-4431-b5bb-648e3d257c32/jobs/1804909?invite=true#step-103-77

I'm not going to touch this here, but whatever we set in

python_version = "3.8"

is completely ignored for Windows.

@pmeier pmeier marked this pull request as ready for review January 10, 2023 15:53
Comment on lines -961 to -965
environment:
PYTHON_VERSION: << parameters.python_version >>
PYTORCH_VERSION: << parameters.pytorch_version >>
UNICODE_ABI: << parameters.unicode_abi >>
CU_VERSION: << parameters.cu_version >>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Driveby. We don't need these here, because they are pulled in at

<<: *binary_common

from

vision/.circleci/config.yml

Lines 222 to 226 in 2b16299

environment:
PYTHON_VERSION: << parameters.python_version >>
PYTORCH_VERSION: << parameters.pytorch_version >>
UNICODE_ABI: << parameters.unicode_abi >>
CU_VERSION: << parameters.cu_version >>

@pmeier pmeier merged commit 90cfb10 into pytorch:main Jan 10, 2023
@github-actions
Copy link

Hey @pmeier!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

@pmeier pmeier deleted the cmake-pin-python branch January 10, 2023 16:27
facebook-github-bot pushed a commit that referenced this pull request Jan 13, 2023
Summary:
* pin python version for macos cmake

* ping python for all OS

* revert to only set this for macos

* debug

* remove debug

Reviewed By: YosuaMichael

Differential Revision: D42500906

fbshipit-source-id: 06dc0b2d979a4b48ca0b6f76f1d58a53ee184ca9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cmake_macos_cpu job failing
3 participants