Remove torch.jit.fuser("fuser2") in test #7069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Internally we're considering removing support for fuser2, so we need to remove this special case from the test.
davidberard98
changed the title
NicolasHug
approved these changes
Jan 10, 2023
There was a problem hiding this comment.
Thanks for the PR and for the detailed context @davidberard98 !
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 10, 2023
Summary:
* [WIP] Remove torch.jit.fuser("fuser2") in test
Internally we're considering removing support for fuser2, so we need to remove this special case from the test.
* completely remove special-casing
Reviewed By: YosuaMichael
Differential Revision: D42431384
fbshipit-source-id: 33c88cc2b54bc76e7541892fc0f9f607d67eb3c7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internally we're considering removing support for fuser2, so we would need to remove this special case from the test.
More context:
torch.jit.fuser('fuser2')(note: fuser2 == NVFuser). The exception to this is for internal usage, where NNC is still used instead of NVFuser.fuser2(NVFuser) tofuser1(NNC) and running this test (as seen here)So, it looks like we can safely remove this special case for
fuser2in this test, which will unblock any internal fuser migration that we may need to do.cc @pmeier