make transforms v2 JIT scriptable #7135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
reviewed
Jan 26, 2023
|
Test failures for |
NicolasHug
reviewed
Jan 27, 2023
| @@ -642,6 +649,74 @@ def test_call_consistency(config, args_kwargs): | |||
| ) | |||
|
|
|||
|
|
|||
| @consistency_configs | |||
There was a problem hiding this comment.
Q: Is it necessary to test JIT support across all consistency configs? I fear that we're adding a lot of test time for little more coverage (but my estimation of the test time could be way off, as well as that of the coverage).
There was a problem hiding this comment.
On my system we are talking about roughly 20 seconds:
pytest test/test_prototype_transforms_consistency.py::test_jit_consistency 21,64s user 1,76s system 185% cpu 12,616 total
I don't think that we are in a realm where we have to worry about CI time yet. Keep in mind, these are not our v2 functional tests, but rather just the consistency ones. In total we only run 143 tests here, which by default check 8 images. So we are at roughly 1k images that we are testing.
NicolasHug
reviewed
Jan 27, 2023
NicolasHug
reviewed
Jan 30, 2023
NicolasHug
approved these changes
Jan 30, 2023
This was referenced Jan 31, 2023
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 8, 2023
Reviewed By: vmoens Differential Revision: D43116123 fbshipit-source-id: 42719d4dae7c7637bc2411b63c375659e59149df
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very early draft for closing #6711. It is based on the idea in #6711 (comment) and requires only very minimal configuration.
ToDO:
cc @vfdev-5 @bjuncek