Fix resnet_fpn_backbone(pretrained=True) #7172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
commented
Feb 3, 2023
test/test_extended_models.py
Outdated
| @@ -425,7 +426,8 @@ def builder(*, weights=None, flag): | |||
| + TM.list_model_fns(models.quantization) | |||
| + TM.list_model_fns(models.segmentation) | |||
| + TM.list_model_fns(models.video) | |||
| + TM.list_model_fns(models.optical_flow), | |||
| + TM.list_model_fns(models.optical_flow) | |||
| + [lambda pretrained: resnet_fpn_backbone(backbone_name="resnet50", pretrained=pretrained)], | |||
There was a problem hiding this comment.
can confirm it fails on main
pmeier
approved these changes
Feb 6, 2023
NicolasHug
added
module: models
other
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 9, 2023
Reviewed By: vmoens Differential Revision: D43116122 fbshipit-source-id: cdd578682e8b643d9e9e4884b986847c1956f1d3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes
resnet_fpn_backbone(pretrained=True)which I broken in #7100Thanks Philip for noticing!