remove int interpolation from elastic #7191
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks Philip, I'm fine removing it. |
NicolasHug
previously approved these changes
Feb 8, 2023
Member
NicolasHug
left a comment
NicolasHug
left a comment
There was a problem hiding this comment.
LGTM when green, thank you
NicolasHug
dismissed
their stale review
Removing approval as we're still discussing whether this deprecation is actually needed (internal users still rely on Pil.Image.BICUBIC)
Contributor
Author
|
Blocked by #7205. |
Contributor
Author
|
Superseded by #7241. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was not included in #7176, since it seems we forgot to put a concrete removal date or better yet an actual deprecation warning in there. So we did warn, but not compliant with our BC policy. Question now is, do we want to move forward with the removal regardless of the point above or do we formally deprecate it now and remove in 0.17?
I lean towards 1., since it is unlikely someone using only
ElasticTransformand thus has seen the concrete deprecation warnings of all other transforms and in turn most likely will also have fixed it here. However, there is no guarantee and so I'm also fine with the other option. In that case let's close this PR and open another one.cc @vfdev-5