Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image and Mask can accept PIL images #7231

Merged
merged 5 commits into from
Feb 13, 2023
Merged

Image and Mask can accept PIL images #7231

merged 5 commits into from
Feb 13, 2023

Conversation

vfdev-5
Copy link
Collaborator

@vfdev-5 vfdev-5 commented Feb 13, 2023 •
edited by pytorch-bot bot
Loading

Description:

  • Fixes "make Image(some_pil_image)" from TODO list (TODOs before 0.15 release #7217)
  • Added tests
  • Updated dataset wrapper
  • Increase tolerence for flaky cpu-bbox-rotation eager vs scripted tests

cc @bjuncek @pmeier

@vfdev-5 vfdev-5 requested a review from pmeier February 13, 2023 15:06
pmeier
pmeier reviewed Feb 13, 2023
View reviewed changes
torchvision/prototype/datapoints/_image.py Outdated Show resolved Hide resolved
test/test_prototype_datapoints.py Outdated Show resolved Hide resolved
NicolasHug
NicolasHug approved these changes Feb 13, 2023
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vfdev-5 !
Changes LGTM if green, let's just wait for @pmeier's input approval as well

torchvision/prototype/datapoints/_image.py Outdated Show resolved Hide resolved
@vfdev-5 vfdev-5 requested a review from pmeier February 13, 2023 15:32
@vfdev-5 vfdev-5 mentioned this pull request Feb 13, 2023
Closed
49 tasks
pmeier
pmeier approved these changes Feb 13, 2023
View reviewed changes
Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Victor!

test/prototype_transforms_kernel_infos.py Show resolved Hide resolved
@NicolasHug NicolasHug merged commit 8fdaeb0 into pytorch:main Feb 13, 2023
@vfdev-5 vfdev-5 deleted the proto-image-mask-accept-pil-images branch February 13, 2023 17:59
facebook-github-bot pushed a commit that referenced this pull request Mar 28, 2023
@NicolasHug @facebook-github-bot
[fbsync] Image and Mask can accept PIL images (#7231)
833f5b9 
Summary: Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>

Reviewed By: vmoens

Differential Revision: D44416255

fbshipit-source-id: 1658cd6b506cb96b9d79ce0f2378ad391cef7a96
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmeier pmeier pmeier approved these changes

@NicolasHug NicolasHug NicolasHug approved these changes

Assignees
No one assigned
Labels
cla signed module: transforms prototype
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vfdev-5 @NicolasHug @pmeier @facebook-github-bot