Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip tests that use assert_run_python_script on windows #7351

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Feb 27, 2023

Parallel to #7346 for speed. I took the condition from

IS_WINDOWS = sys.platform in ("win32", "cygwin")

since I don't have a Windows box to test it myself.

cc @vfdev-5

@NicolasHug NicolasHug merged commit 1cd95e6 into pytorch:main Feb 27, 2023
@github-actions
Copy link

Hey @NicolasHug!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

@pmeier pmeier deleted the windows-assert-run-skip branch February 27, 2023 15:27
pmeier added a commit to pmeier/vision that referenced this pull request Feb 27, 2023
pmeier added a commit to pmeier/vision that referenced this pull request Feb 27, 2023
facebook-github-bot pushed a commit that referenced this pull request Mar 30, 2023
Reviewed By: vmoens

Differential Revision: D44416640

fbshipit-source-id: 0ebceef6717d0900f019631d5506900928d553af
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants