Add smoke test Using a simple RN50 with torch.compile #7359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmeier
reviewed
Feb 27, 2023
test/smoke_test.py
Outdated
Comment on lines
34
to
35
| out = model(x) | ||
| print(out.shape) |
There was a problem hiding this comment.
pytest will swallow all outputs unless the test is failing. Can we maybe assert the expected shape?
There was a problem hiding this comment.
@pmeier We basically want to see if compile works in this PR. As per: pytorch/builder#1318
Will do more testing of this and perhaps add assert as you suggest in the next PR.
NicolasHug
approved these changes
Feb 28, 2023
|
Hey @atalman! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
|
@atalman should we cherry-pick that into the release branch immediately, or do we need to made for a new RC to be cut first? |
|
@NicolasHug no not necessary for cherry pick since we are running tests from main. |
This was referenced Mar 1, 2023
Merged
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 30, 2023
Reviewed By: vmoens Differential Revision: D44416574 fbshipit-source-id: 56a43636a40751a588aef96f22346304f6f29995
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add smoke test based on: pytorch/builder#1318