fix flaky test for rotate_bounding_box #7362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @NicolasHug! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
NicolasHug
added a commit
to NicolasHug/vision
that referenced
this pull request
Mar 1, 2023
Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
This was referenced Mar 1, 2023
NicolasHug
added a commit
to NicolasHug/vision
that referenced
this pull request
Mar 1, 2023
Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 30, 2023
Summary: Co-authored-by: Nicolas Hug <contact@nicolas-hug.com> Reviewed By: vmoens Differential Revision: D44416587 fbshipit-source-id: c9917d398e438391031f6bb523ec3a52281094a0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://app.circleci.com/pipelines/github/pytorch/vision/23712/workflows/71c48632-734a-42bc-b2fe-bbdf64f9dcd3/jobs/1845129/tests.
Apart from that there is also a flaky failure for the same op on
test_cuda_vs_cpu: https://github.com/pytorch/vision/actions/runs/4292476270/jobs/7478954697#step:10:2949.That one is really weird given that we are calling the same op multiple times with the input data on same dtype and device so there shouldn't be any flakiness. I've improved the error messages to include the full input data the next time this happens, since I cannot reproduce.
The error happens for
XYWHand internallyrotate_bounding_boxconverts toXYXYand back. The dtype istorch.int64so there might be rounding issues. But no idea why there would be different behavior when calling the op with a batch or not.