Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PoC] migrate docs workflow to GHA #7407

Merged
merged 13 commits into from
Mar 15, 2023
Merged

[PoC] migrate docs workflow to GHA #7407

merged 13 commits into from
Mar 15, 2023

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Mar 10, 2023

I don't intend to merge this PR at this point, since we need to resolve the doc preview issue on GHA first. In pytorch/test-infra#3842 @DanilBaibak enabled Dr. CI, i.e. the bot that will comment below, for torchvision again. Although it doesn't work yet, the artifact generated by the workflow added in this PR needs to be uploaded to a S3 bucket similar to what is done in PyTorch core. If I'm not mistaken, we only need to have a second job that depends on the one I added, that downloads the artifact and uploads it again to S3.

I ignored some intricacies here, like nightly doc upload and release branch version fix:

vision/.circleci/config.yml

Lines 893 to 895 in 82cf540

# turn v1.12.0rc3 into 1.12.0
tag=$(echo $CIRCLE_TAG | sed -e 's/v*\([0-9.]*\).*/\1/')
VERSION=${tag:-main}

cc @seemethere

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 10, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7407

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pmeier pmeier mentioned this pull request Mar 10, 2023
21 tasks
@pmeier
Copy link
Collaborator Author

pmeier commented Mar 10, 2023

Jobs is green: https://github.com/pytorch/vision/actions/runs/4383643063/jobs/7674140541. Documentation is available as artifact: https://github.com/pytorch/vision/actions/runs/4383643063. I've verified that it is ok.

@malfet
Copy link
Contributor

malfet commented Mar 15, 2023

So, upload fails because you need to run the build on pytorch org runner rather than on a stock github one

.github/workflows/docs.yml Outdated Show resolved Hide resolved
.github/workflows/docs.yml Outdated Show resolved Hide resolved
@malfet
Copy link
Contributor

malfet commented Mar 15, 2023

I can see doc preview now (need to fix URL in the hud though): https://docs-preview.pytorch.org/vision/7407/index.html

@malfet malfet marked this pull request as ready for review March 15, 2023 19:14
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see the preview, which means change is good to go: https://docs-preview.pytorch.org/vision/7407/index.html

@malfet malfet merged commit 8e07897 into pytorch:main Mar 15, 2023
@github-actions
Copy link

Hey @malfet!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

@pmeier pmeier deleted the docs-gha branch March 15, 2023 19:17
facebook-github-bot pushed a commit that referenced this pull request Mar 30, 2023
Summary: Co-authored-by: Nikita Shulga <nikita.shulga@gmail.com>

Reviewed By: vmoens

Differential Revision: D44416559

fbshipit-source-id: 48db0e9e718954b3c0313df2cf3214d178d3fa5c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants