-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PoC] migrate docs workflow to GHA #7407
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7407
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Jobs is green: https://github.com/pytorch/vision/actions/runs/4383643063/jobs/7674140541. Documentation is available as artifact: https://github.com/pytorch/vision/actions/runs/4383643063. I've verified that it is ok. |
So, upload fails because you need to run the build on pytorch org runner rather than on a stock github one |
I can see doc preview now (need to fix URL in the hud though): https://docs-preview.pytorch.org/vision/7407/index.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see the preview, which means change is good to go: https://docs-preview.pytorch.org/vision/7407/index.html
Hey @malfet! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
Summary: Co-authored-by: Nikita Shulga <nikita.shulga@gmail.com> Reviewed By: vmoens Differential Revision: D44416559 fbshipit-source-id: 48db0e9e718954b3c0313df2cf3214d178d3fa5c
I don't intend to merge this PR at this point, since we need to resolve the doc preview issue on GHA first. In pytorch/test-infra#3842 @DanilBaibak enabled Dr. CI, i.e. the bot that will comment below, for
torchvision
again. Although it doesn't work yet, the artifact generated by the workflow added in this PR needs to be uploaded to a S3 bucket similar to what is done in PyTorch core. If I'm not mistaken, we only need to have a second job that depends on the one I added, that downloads the artifact and uploads it again to S3.I ignored some intricacies here, like nightly doc upload and release branch version fix:
vision/.circleci/config.yml
Lines 893 to 895 in 82cf540
cc @seemethere