-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add PermuteChannels transform #7624
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather just call it ChannelShuffle
for consistency with the other package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pmeier , approving to unblock with a few comments
I'd rather just call it ChannelShuffle for consistency with the other package
I'm taking this back because of what it would mean for the functional name... All options seem to have some rather annoying downside. I'll let you decide.
Reviewed By: matteobettini Differential Revision: D48642277 fbshipit-source-id: 44b1154ab894869f014e2ad2e8367832085d948d
Closes #7620. I need to add proper test for the functionals. Happy to bikeshed on the name. I went with
permute_channels
, because that is what we had before. But "shuffle channels" as proposed in #7620 is also an option.cc @vfdev-5