Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add PermuteChannels transform #7624

Merged
merged 11 commits into from
Aug 9, 2023
Merged

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented May 24, 2023

Closes #7620. I need to add proper test for the functionals. Happy to bikeshed on the name. I went with permute_channels, because that is what we had before. But "shuffle channels" as proposed in #7620 is also an option.

cc @vfdev-5

@pytorch-bot
Copy link

pytorch-bot bot commented May 24, 2023

@pmeier pmeier marked this pull request as ready for review August 7, 2023 12:14
@pmeier pmeier requested a review from NicolasHug August 7, 2023 12:14
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather just call it ChannelShuffle for consistency with the other package

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pmeier , approving to unblock with a few comments

I'd rather just call it ChannelShuffle for consistency with the other package

I'm taking this back because of what it would mean for the functional name... All options seem to have some rather annoying downside. I'll let you decide.

torchvision/transforms/v2/_color.py Outdated Show resolved Hide resolved
test/test_transforms_v2_refactored.py Outdated Show resolved Hide resolved
torchvision/transforms/v2/_color.py Outdated Show resolved Hide resolved
test/test_transforms_v2_refactored.py Show resolved Hide resolved
test/test_transforms_v2_refactored.py Outdated Show resolved Hide resolved
@pmeier pmeier merged commit 5d8d61a into pytorch:main Aug 9, 2023
@pmeier pmeier deleted the random-channel-permute branch August 9, 2023 08:48
@NicolasHug NicolasHug mentioned this pull request Aug 9, 2023
facebook-github-bot pushed a commit that referenced this pull request Aug 25, 2023
Reviewed By: matteobettini

Differential Revision: D48642277

fbshipit-source-id: 44b1154ab894869f014e2ad2e8367832085d948d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ChannelShuffle transforms
4 participants