upgrade linters #7680
Open
upgrade linters #7680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7680
Note: Links to docs will display an error until the docs builds have been completed. ✅ 3 Unrelated FailuresAs of commit f7aebe8: BROKEN TRUNK - The following jobs failed but were present on the merge base 22d981f:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
NicolasHug
reviewed
Jun 20, 2023
.pre-commit-config.yaml
Outdated
Comment on lines
18
to
19
| - black == 23.3.0 | ||
| - usort == 1.0.7 |
There was a problem hiding this comment.
We can't, unfortunately.
We have to stick to what is used by pyfmt internally
nicolashug@devvm779 ~ ❯❯❯ pyfmt --version
fb-pyfmt built mode/opt (xar) on Python 3.10.9+fb (platform010)
ufmt version 2.0.1
black version 22.12.0
usort version 1.0.5
libcst version 0.4.10
There was a problem hiding this comment.
Updated the config to match the pyfmt requirements.
pmeier
added
the
other
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important file to review is
.pre-commit-config.yaml. Everything else are automatic changes. The major ones:As suspected in remove obsolete transforms tests #7678 (comment),
black >= 23removes blank lines after function definitions, which accounts for most of the removals in this PR.flake8==6gained the support to check for individual unused imports. Meaningwas fine before, but will now be flagged, since
bazis unused. Sinceflake8doesn't account for (ancient)# typecomments, we had a lot of false flags. I've usedcom2annto migrate to best practice of using inline annotations.@mpearce25 I only now remembered that you have #7222 for the
flake8update. I'm sorry that I forgot about it. In case we move forward with my PR here, are you ok if I attribute you as co-author here and close the original PR?