Add GPU support for draw_segmentation_masks

[mshr-h]

#7683

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7684

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 7 New Failures

As of commit 43e8034:

NEW FAILURES - The following jobs have failed:

• pytorch/vision / manywheel-py3_8-rocm5_4_2 (gh)
• unittests-macos (3.8, macos-m1-12) / macos-job (gh)
• unittests-windows (3.10, windows.4xlarge, cpu) / windows-job (gh)
• unittests-windows (3.11, windows.4xlarge, cpu) / windows-job (gh)
• unittests-windows (3.8, windows.4xlarge, cpu) / windows-job (gh)
• unittests-windows (3.9, windows.4xlarge, cpu) / windows-job (gh)
• windows (windows.4xlarge, cpu) / windows-job (gh)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[facebook-github-bot]

Hi @mshr-h!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

[NicolasHug]

Thanks for the PR @mshr-h . We should probably add a quick test to make sure it works as expected, by e.g. adding the cpu_and_gpu() decorator to this test:

vision/test/test_utils.py

Line 206 in fc83b28

def test_draw_segmentation_masks(colors, alpha):

See

vision/test/test_functional_tensor.py

Lines 542 to 543 in fc83b28

	@pytest.mark.parametrize("device", cpu_and_gpu())
	def test_resize_asserts(device):

for an example of how it's used

[mshr-h]

Thank you for your quick review.
I updated the unit test.

I need to ask my employer to sign the CLA. I guess it takes a few weeks.

[pmeier]

CI failures are unrelated. Thanks a lot @mshr-h!

I need to ask my employer to sign the CLA. I guess it takes a few weeks.

Unfortunately, we cannot merge until that is done. We should get a notification as soon as that is done, but in case we miss it, feel free to ping us here.

[mshr-h]

@pmeier
I've completed signing the CLA.

[NicolasHug]

Thanks @mshr-h , I fixed a conflict issue and I'll merge when green

[NicolasHug]

I'll leave this here to avoid churn but we typically don't need to run those tests on cuda, as there's nothing cuda-spcecific there. Same for test_draw_no_segmention_mask