port rotate #7713
Merged
port rotate #7713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmeier
commented
Jun 30, 2023
NicolasHug
reviewed
Jun 30, 2023
NicolasHug
reviewed
Jun 30, 2023
NicolasHug
approved these changes
Jul 3, 2023
| elif input_type is PIL.Image.Image: | ||
| input = F.to_image_pil(input) | ||
| elif input_type is datapoints.BoundingBox: | ||
| kwargs.setdefault("format", datapoints.BoundingBoxFormat.XYXY) |
There was a problem hiding this comment.
Shouldn't this logic be part of make_bounding_box's contract? (same for the dtype logic)
This is the kind of changes that makes me think we should already be moving away from the utils in common_utils for input generation, as suggested earlier #7562 (comment).
We can delay it but we'll have to do it eventually anyway, and IMO the earlier we do it, the more control we'll have.
There was a problem hiding this comment.
Will have a go at it after this PR before I port anything more.
|
Hey @pmeier! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 25, 2023
Reviewed By: matteobettini Differential Revision: D48642318 fbshipit-source-id: dfcb7ca6a837104bc0acfe3ba2f66bb9ecef267b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also acts on #7703 (comment).
cc @vfdev-5