Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docstring example for resnet_fpn_backbone #7957

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

kit1980
Copy link
Member

@kit1980 kit1980 commented Sep 11, 2023

Add missing imports and fix deprecated use of `backbone_name' as positional parameter.

Add missing imports and use fix deprecated use of `backbone_name' as positional parameter.
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 11, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7957

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 9381d8b with merge base 0b41ff0 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@kit1980 kit1980 requested a review from pmeier September 11, 2023 23:39
@kit1980 kit1980 marked this pull request as ready for review September 11, 2023 23:43
Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! However, I can't find any mention of this function in the docs.

@@ -79,8 +79,10 @@ def resnet_fpn_backbone(

Examples::

>>> import torch
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need this import here? That should be obvious, isn't it?

Copy link
Member Author

@kit1980 kit1980 Sep 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This way it's copy-pastable to ipython and maybe eventually we can enable doctests.

@kit1980 kit1980 merged commit 75046bd into main Sep 14, 2023
@github-actions
Copy link

Hey @kit1980!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

facebook-github-bot pushed a commit that referenced this pull request Sep 26, 2023
Reviewed By: matteobettini

Differential Revision: D49600792

fbshipit-source-id: 0b8a8da567a09fe4df546e8e5b8a775d8d8a0c4f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants