Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port tests for transforms.Lambda #8011

Merged
merged 2 commits into from
Oct 3, 2023
Merged

port tests for transforms.Lambda #8011

merged 2 commits into from
Oct 3, 2023

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Oct 2, 2023

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 2, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8011

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit bddfb87 with merge base b6189a8 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pmeier , LGTM

Related, but can be done in anoter PR:

  • types param is not documented
  • Ideally it should support a single type instead of enforcing an iterable to be passed

@pmeier
Copy link
Collaborator Author

pmeier commented Oct 3, 2023

Ideally it should support a single type instead of enforcing an iterable to be passed

It takes *types so you can pass a single type:

def __init__(self, lambd: Callable[[Any], Any], *types: Type):

@pmeier pmeier merged commit 0040fe7 into pytorch:main Oct 3, 2023
11 of 35 checks passed
@pmeier pmeier deleted the port/lambda branch October 3, 2023 19:48
@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Hey @pmeier!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

facebook-github-bot pushed a commit that referenced this pull request Oct 31, 2023
Reviewed By: vmoens

Differential Revision: D50789100

fbshipit-source-id: 96b51f5e25569a943cbafe04f9afcd57e2f94959
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants