Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mypy on VisionDataset #8134

Merged
merged 1 commit into from
Nov 23, 2023
+2 −2
Merged

fix mypy on VisionDataset #8134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion torchvision/datasets/fakedata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ def __init__(
target_transform: Optional[Callable] = None,
random_offset: int = 0,
) -> None:
super().__init__(None, transform=transform, target_transform=target_transform) # type: ignore[arg-type]
super().__init__(transform=transform, target_transform=target_transform)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Driveby, since we no longer need to pass None after #8124.

self.size = size
self.num_classes = num_classes
self.image_size = image_size
Expand Down
2 changes: 1 addition & 1 deletion torchvision/datasets/vision.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ class VisionDataset(data.Dataset):

def __init__(
self,
root: Optional[str] = None,
root: str = None, # type: ignore[assignment]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we still keep the Optional[str] type which is technically correct?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't. If we use Optional[str] as annotation, mypy correctly infers that for the self.root attribute. And with that we are back at the issues we are currently seeing, i.e. all child datasets that perform anything with self.root would now need to check that self.root is in fact a str and not None.

transforms: Optional[Callable] = None,
transform: Optional[Callable] = None,
target_transform: Optional[Callable] = None,
Expand Down
Loading