Pass use_reentrant for checkpoint #8180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8180
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit db7bce1 with merge base 26fb5ef ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
kit1980
force-pushed
the
sdym/use_reentrant
branch
from
8092b6c to
db7bce1
Compare
|
Hey @pmeier! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 16, 2024
Reviewed By: vmoens Differential Revision: D52538997 fbshipit-source-id: cf67bec41fc4fc8266c3552579faff8b12d91352
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After pytorch/pytorch#115868
checkpointrequires passinguse_reentrant.See https://dev-discuss.pytorch.org/t/bc-breaking-update-to-torch-utils-checkpoint-not-passing-in-use-reentrant-flag-will-raise-an-error/1745 for more info.
The tests are currently failing with unrelated
AttributeError: module 'expecttest' has no attribute 'ACCEPT'