-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add notes about BoundingBoxes transform utils in ops/boxes docstrings #8197
Conversation
Updated description of torchvision.ops.boxes.box_convert() to improve user interaction with the more up to date function `torchvision.transforms.v2.functional.convert_bounding_box_format`
Referenced v2 transforms for remove_small_boxes, clip_boxes_to_image, and box_area.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8197
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (9 Unrelated Failures)As of commit f100194 with merge base 71b27a0 (): FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Hi @bmmtstb! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the PR @bmmtstb ! It looks great, I just made some minor comments below regarding formatting. LMK what you think
Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
I implemented the requested changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @bmmtstb !!
…pytorch#8197) Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
…ocstrings (#8197) Summary: Co-authored-by: Nicolas Hug <contact@nicolas-hug.com> Reviewed By: vmoens Differential Revision: D55062787 fbshipit-source-id: c0dec163f99f42114bb9d71e0ff4e2fb4a80e83e
Added documentation to multiple functions in
torchvision.ops.boxes
as proposed by #8190 .