Add visibility parameter to draw_keypoints()

[bmmtstb]

Added visibility attribute to draw_keypoints
Added another section to the draw_keypoints example in the gallery
Added tests in test_utils

I'm not entirely sure how to full / properly test the skipped connections, but in visual inspection everything seems fine.

Waiting for your comments @NicolasHug

A few things to note:

• Within draw_keypoints() num_instances and N gets used to describe the same thing. Possibly double check that.
• "keypoints", "key_points", or "key points" ? I'm no native so I used the same spelling that was in the documentation by the people before me.
• I used ~torch.Tensor as type hint for the visibility, not ~torch.BoolTensor.

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8225

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (27 Unrelated Failures)

As of commit 39d23b7 with merge base 36d0e3e ():

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

• CMake / linux (linux.12xlarge, cpu) / linux-job (gh)
  The process '/usr/bin/git' failed with exit code 128
• CMake / linux (linux.g5.4xlarge.nvidia.gpu, cuda, 11.8) / linux-job (gh)
  The process '/usr/bin/git' failed with exit code 128
• CMake / macos (macos-12) / macos-job (gh)
  The process '/usr/local/bin/git' failed with exit code 128
• CMake / macos (macos-m1-stable) / macos-job (gh)
  The process '/usr/bin/git' failed with exit code 128
• CMake / windows (windows.4xlarge, cpu) / windows-job (gh)
  The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
• CMake / windows (windows.g5.4xlarge.nvidia.gpu, cuda, 11.8) / windows-job (gh)
  The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
• Prototype tests on Linux / unittests-prototype (3.10, linux.12xlarge, cpu) / linux-job (gh)
  The process '/usr/bin/git' failed with exit code 128
• Prototype tests on Linux / unittests-prototype (3.11, linux.12xlarge, cpu) / linux-job (gh)
  The process '/usr/bin/git' failed with exit code 128
• Prototype tests on Linux / unittests-prototype (3.8, linux.12xlarge, cpu) / linux-job (gh)
  The process '/usr/bin/git' failed with exit code 128
• Prototype tests on Linux / unittests-prototype (3.8, linux.g5.4xlarge.nvidia.gpu, cuda, 11.8) / linux-job (gh)
  The process '/usr/bin/git' failed with exit code 128
• Prototype tests on Linux / unittests-prototype (3.9, linux.12xlarge, cpu) / linux-job (gh)
  The process '/usr/bin/git' failed with exit code 128
• Tests / unittests-linux (3.10, linux.12xlarge, cpu) / linux-job (gh)
  The process '/usr/bin/git' failed with exit code 128
• Tests / unittests-linux (3.11, linux.12xlarge, cpu) / linux-job (gh)
  The process '/usr/bin/git' failed with exit code 128
• Tests / unittests-linux (3.8, linux.12xlarge, cpu) / linux-job (gh)
  The process '/usr/bin/git' failed with exit code 128
• Tests / unittests-linux (3.8, linux.g5.4xlarge.nvidia.gpu, cuda, 11.8) / linux-job (gh)
  The process '/usr/bin/git' failed with exit code 128
• Tests / unittests-linux (3.9, linux.12xlarge, cpu) / linux-job (gh)
  The process '/usr/bin/git' failed with exit code 128
• Tests / unittests-macos (3.10, macos-12) / macos-job (gh)
  The process '/usr/local/bin/git' failed with exit code 128
• Tests / unittests-macos (3.11, macos-12) / macos-job (gh)
  The process '/usr/local/bin/git' failed with exit code 128
• Tests / unittests-macos (3.8, macos-12) / macos-job (gh)
  The process '/usr/local/bin/git' failed with exit code 128
• Tests / unittests-macos (3.8, macos-m1-stable) / macos-job (gh)
  The process '/usr/bin/git' failed with exit code 128
• Tests / unittests-macos (3.9, macos-12) / macos-job (gh)
  The process '/usr/local/bin/git' failed with exit code 128
• Tests / unittests-windows (3.10, windows.4xlarge, cpu) / windows-job (gh)
  The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
• Tests / unittests-windows (3.11, windows.4xlarge, cpu) / windows-job (gh)
  The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
• Tests / unittests-windows (3.8, windows.4xlarge, cpu) / windows-job (gh)
  The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
• Tests / unittests-windows (3.8, windows.g5.4xlarge.nvidia.gpu, cuda, 11.8) / windows-job (gh)
  The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
• Tests / unittests-windows (3.9, windows.4xlarge, cpu) / windows-job (gh)
  The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

• Build Windows Conda / pytorch/vision / conda-py3_8-cpu (gh)
  Process completed with exit code 1.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[bmmtstb]

I diddn't run ufmt and flake on the gallery and tests, my bad. Now everything worked locally.

I'm still wondering about how to display the new prediction matrix. "000.000" looks nice but is not good practice. And if I want the values to align, I can't use spaces.

https://github.com/bmmtstb/vision/blob/dd9b16a8467b689e7e7f55dd57e521669aac8fa1/gallery/others/plot_visualization_utils.py#L473-L491

[NicolasHug]

Thanks a ton @bmmtstb , I made a few comments but this looks great already!

[bmmtstb]

@NicolasHug I implemented most of your requests.
And for the last open unresolved comment, I referenced the link in the visibility attribute. If that solves it for you, feel free to close it.

Additionally, I could add a test against a dummy image as proposed by you. Sadly I needed to create a new image and couldn't reuse the existing one, see comments above.

[NicolasHug]

Thank you so much @bmmtstb , some last comments below but this looks great. I can take care of addressing those comments if you prefer, LMK

[NicolasHug]

Thank you so much @bmmtstb !