Added Type Check for cocodetection dataset

[RazaProdigy]

Fixes #7824

###Key changes:

For now added type checking in getitem function of cocodetection (coco.py) to ensure value passed is int and not a slice.
Current getitem function does not handle slice inputs and returns wrong result.
We can also work on enhancing the code to allow for slice inputs. Please do let me know if this feature is required i can work on it.

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8227

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 14 New Failures, 18 Unrelated Failures

As of commit 3187381 with merge base 6d64cb3 ():

NEW FAILURES - The following jobs have failed:

• CMake / macos (macos-12) / macos-job (gh)
  The process '/usr/local/bin/git' failed with exit code 128
• CMake / macos (macos-m1-stable) / macos-job (gh)
  The process '/usr/bin/git' failed with exit code 128
• CMake / windows (windows.4xlarge, cpu) / windows-job (gh)
  The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
• CMake / windows (windows.g5.4xlarge.nvidia.gpu, cuda, 11.8) / windows-job (gh)
  The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
• Tests / unittests-macos (3.10, macos-12) / macos-job (gh)
  The process '/usr/local/bin/git' failed with exit code 128
• Tests / unittests-macos (3.11, macos-12) / macos-job (gh)
  The process '/usr/local/bin/git' failed with exit code 128
• Tests / unittests-macos (3.8, macos-12) / macos-job (gh)
  The process '/usr/local/bin/git' failed with exit code 128
• Tests / unittests-macos (3.8, macos-m1-stable) / macos-job (gh)
  The process '/usr/bin/git' failed with exit code 128
• Tests / unittests-macos (3.9, macos-12) / macos-job (gh)
  The process '/usr/local/bin/git' failed with exit code 128
• Tests / unittests-windows (3.10, windows.4xlarge, cpu) / windows-job (gh)
  The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
• Tests / unittests-windows (3.11, windows.4xlarge, cpu) / windows-job (gh)
  The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
• Tests / unittests-windows (3.8, windows.4xlarge, cpu) / windows-job (gh)
  The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
• Tests / unittests-windows (3.8, windows.g5.4xlarge.nvidia.gpu, cuda, 11.8) / windows-job (gh)
  The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
• Tests / unittests-windows (3.9, windows.4xlarge, cpu) / windows-job (gh)
  The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

• CMake / linux (linux.12xlarge, cpu) / linux-job (gh)
  The process '/usr/bin/git' failed with exit code 128
• CMake / linux (linux.g5.4xlarge.nvidia.gpu, cuda, 11.8) / linux-job (gh)
  The process '/usr/bin/git' failed with exit code 128
• Docs / build / linux-job (gh)
  The process '/usr/bin/git' failed with exit code 128
• Lint / c-source / linux-job (gh)
  The process '/usr/bin/git' failed with exit code 128
• Lint / python-source-and-configs / linux-job (gh)
  The process '/usr/bin/git' failed with exit code 128
• Lint / python-types / linux-job (gh)
  The process '/usr/bin/git' failed with exit code 128
• Prototype tests on Linux / unittests-prototype (3.10, linux.12xlarge, cpu) / linux-job (gh)
  The process '/usr/bin/git' failed with exit code 128
• Prototype tests on Linux / unittests-prototype (3.11, linux.12xlarge, cpu) / linux-job (gh)
  The process '/usr/bin/git' failed with exit code 128
• Prototype tests on Linux / unittests-prototype (3.8, linux.12xlarge, cpu) / linux-job (gh)
  The process '/usr/bin/git' failed with exit code 128
• Prototype tests on Linux / unittests-prototype (3.8, linux.g5.4xlarge.nvidia.gpu, cuda, 11.8) / linux-job (gh)
  The process '/usr/bin/git' failed with exit code 128
• Prototype tests on Linux / unittests-prototype (3.9, linux.12xlarge, cpu) / linux-job (gh)
  The process '/usr/bin/git' failed with exit code 128
• Tests / onnx / linux-job (gh)
  The process '/usr/bin/git' failed with exit code 128
• Tests / unittests-extended / linux-job (gh)
  The process '/usr/bin/git' failed with exit code 128
• Tests / unittests-linux (3.10, linux.12xlarge, cpu) / linux-job (gh)
  The process '/usr/bin/git' failed with exit code 128
• Tests / unittests-linux (3.11, linux.12xlarge, cpu) / linux-job (gh)
  The process '/usr/bin/git' failed with exit code 128
• Tests / unittests-linux (3.8, linux.12xlarge, cpu) / linux-job (gh)
  The process '/usr/bin/git' failed with exit code 128
• Tests / unittests-linux (3.8, linux.g5.4xlarge.nvidia.gpu, cuda, 11.8) / linux-job (gh)
  The process '/usr/bin/git' failed with exit code 128
• Tests / unittests-linux (3.9, linux.12xlarge, cpu) / linux-job (gh)
  The process '/usr/bin/git' failed with exit code 128

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[facebook-github-bot]

Hi @RazaProdigy!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[NicolasHug]

Thanks for the PR @RazaProdigy, and thanks @sadra-barikbin for the original report.

The changes LGTM. Before merging, could you please add a small non-regression test here:

vision/test/test_datasets.py

Line 829 in 6f0deb9

Something like this (I haven't checked that it works):

    def test_slice_error(self):
        with self.create_dataset() as (dataset, _):
            with pytest.raises(ValueError, match="Index must be of  type integer"):
                dataset[:2]

Thank you!

[RazaProdigy]

@NicolasHug Test seems to pass!
Thanks!

[NicolasHug]

Thanks a lot @RazaProdigy