Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix int/float typing in video_utils.py #8234

Merged
merged 4 commits into from
Jan 31, 2024
Merged

Conversation

bryant1410
Copy link
Contributor

Many of these types that accept ints are actually already accepting floats.

Also, remove old-style unnecessary conversion to float.

Copy link

pytorch-bot bot commented Jan 26, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8234

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit 96031fa with merge base 0be6c7e (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@bryant1410
Copy link
Contributor Author

I now converted the Union[int, float] into float, following https://stackoverflow.com/a/50928627/1165181.

@bryant1410
Copy link
Contributor Author

I don't understand the test failures. Are they false positives?

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @bryant1410

@NicolasHug NicolasHug merged commit 806dba6 into pytorch:main Jan 31, 2024
78 of 80 checks passed
@bryant1410 bryant1410 deleted the patch-3 branch January 31, 2024 14:05
facebook-github-bot pushed a commit that referenced this pull request Mar 20, 2024
Summary: Co-authored-by: Nicolas Hug <nh.nicolas.hug@gmail.com>

Reviewed By: vmoens

Differential Revision: D55062804

fbshipit-source-id: a880482450d6275597bec500648ff1e085b65a39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants