-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore mypy for prototype.transforms.*
#8403
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8403
Note: Links to docs will display an error until the docs builds have been completed. ❌ 16 New Failures, 20 Unrelated FailuresAs of commit 8ac6db3 with merge base 11db385 (): NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pmeier
approved these changes
May 3, 2024
Hey @NicolasHug! You merged this PR, but no labels were added. |
facebook-github-bot
pushed a commit
that referenced
this pull request
May 8, 2024
Reviewed By: vmoens Differential Revision: D57099454 fbshipit-source-id: 56a8923b6a56a1bb2794f29be847d44259eec97a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #8377
This removes the following mypy errors:
Those are (I assume) partly due to incorrect annotation, partly due to incompatibilities between torchscript and mypy. In any case, this is the prototype module and that file only contains the stereo presets which is an area that hasn't been developed/maintained in a while.
cc @bjuncek