Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More mypy fixes/ignores #8412

Merged
merged 3 commits into from
May 7, 2024
Merged

Conversation

NicolasHug
Copy link
Member

@NicolasHug NicolasHug commented May 7, 2024

Closes #8377

cc @vfdev-5

Copy link

pytorch-bot bot commented May 7, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8412

Note: Links to docs will display an error until the docs builds have been completed.

❌ 14 New Failures, 2 Unrelated Failures

As of commit bdc6f4b with merge base f766d7a (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@NicolasHug NicolasHug marked this pull request as ready for review May 7, 2024 12:43
@NicolasHug NicolasHug changed the title WIP more mypy fixes/ignores More mypy fixes/ignores May 7, 2024
Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @NicolasHug!

@@ -94,6 +94,7 @@ def _apply_image_or_video_transform(
interpolation: Union[InterpolationMode, int],
fill: Dict[Union[Type, str], _FillTypeJIT],
) -> ImageOrVideo:
image = cast(torch.Tensor, image)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a comment here that this cast is wrong and we are only doing this for JIT.

@NicolasHug NicolasHug merged commit d23a6e1 into pytorch:main May 7, 2024
50 of 66 checks passed
@NicolasHug NicolasHug deleted the alejnfalefjnaljnef branch May 7, 2024 13:02
facebook-github-bot pushed a commit that referenced this pull request May 8, 2024
Reviewed By: vmoens

Differential Revision: D57099467

fbshipit-source-id: 2c94c9201335601bd28969d9bfabdae33db4cfa3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mypy job is broken
3 participants