-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed from torch.cuda.amp.autocast to torch.amp.autocast #8508
base: main
Are you sure you want to change the base?
Conversation
torch.cuda.amp.autocast to be deprecated
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8508
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Hi @jamesmuking5! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the PR @jamesmuking5 .
The changes LGTM but I would suggest to just replace with torch.amp.autocast("cuda", ...)
since none of those are expected to be on CPU.
If you can, it'd be great to also address the rest of the occurrences or torch.cuda.amp.*
(I could find the ones below), but I can do that in a follow-up PR if you prefer. Thanks!
~/dev/vision (main*) » git grep torch.cuda.amp nicolashug@nicolashug-fedora-PF372ZT9
references/classification/README.md:Automatic Mixed Precision (AMP) training on GPU for Pytorch can be enabled with the [torch.cuda.amp](https://pytorch.org/docs/stable/amp.html?highlight=amp#module-torch.cuda.amp).
references/classification/train.py: with torch.cuda.amp.autocast(enabled=scaler is not None):
references/classification/train.py: scaler = torch.cuda.amp.GradScaler() if args.amp else None
references/classification/train.py: parser.add_argument("--amp", action="store_true", help="Use torch.cuda.amp for mixed precision training")
references/depth/stereo/cascade_evaluation.py: with torch.cuda.amp.autocast(enabled=args.mixed_precision, dtype=torch.float16):
references/depth/stereo/train.py: with torch.cuda.amp.autocast(enabled=args.mixed_precision, dtype=torch.float16):
references/depth/stereo/train.py: with torch.cuda.amp.autocast(enabled=args.mixed_precision, dtype=torch.float16):
references/depth/stereo/train.py: scaler = torch.cuda.amp.GradScaler() if args.mixed_precision else None
references/detection/engine.py: with torch.cuda.amp.autocast(enabled=scaler is not None):
references/detection/train.py: parser.add_argument("--amp", action="store_true", help="Use torch.cuda.amp for mixed precision training")
references/detection/train.py: scaler = torch.cuda.amp.GradScaler() if args.amp else None
references/segmentation/train.py: with torch.cuda.amp.autocast(enabled=scaler is not None):
references/segmentation/train.py: scaler = torch.cuda.amp.GradScaler() if args.amp else None
references/segmentation/train.py: parser.add_argument("--amp", action="store_true", help="Use torch.cuda.amp for mixed precision training")
references/video_classification/train.py: with torch.cuda.amp.autocast(enabled=scaler is not None):
references/video_classification/train.py: scaler = torch.cuda.amp.GradScaler() if args.amp else None
references/video_classification/train.py: parser.add_argument("--amp", action="store_true", help="Use torch.cuda.amp for mixed precision training")
test/test_models.py: with torch.cuda.amp.autocast():
test/test_models.py: with torch.cuda.amp.autocast():
test/test_models.py: with torch.cuda.amp.autocast(), torch.no_grad(), freeze_rng_state():
test/test_models.py: with torch.cuda.amp.autocast(), torch.no_grad(), freeze_rng_state():
test/test_models.py: with torch.cuda.amp.autocast():
test/test_ops.py: with torch.cuda.amp.autocast():
test/test_ops.py: with torch.cuda.amp.autocast():
test/test_ops.py: with torch.cuda.amp.autocast():
test/test_ops.py: with torch.cuda.amp.autocast():
torch.cuda.amp.autocast
to be deprecated