Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin numpy dep to numpy<2 for windows #8530

Merged
merged 3 commits into from
Jul 17, 2024

Conversation

NicolasHug
Copy link
Member

@NicolasHug NicolasHug commented Jul 16, 2024

Temporary measure to keep the CI green. Related to #8531

Copy link

pytorch-bot bot commented Jul 16, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8530

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Unrelated Failures

As of commit 276ba34 with merge base 33e47d8 (image):

NEW FAILURE - The following job has failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@NicolasHug NicolasHug changed the title use numpy<2??? Pin numpy dep to numpy<2 for windows Jul 17, 2024
@NicolasHug NicolasHug merged commit 0bf8d14 into pytorch:main Jul 17, 2024
72 of 75 checks passed
@NicolasHug NicolasHug deleted the numpy2_windows branch July 17, 2024 09:41
Copy link

Hey @NicolasHug!

You merged this PR, but no labels were added.
The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

@NicolasHug NicolasHug added the other if you have no clue or if you will manually handle the PR in the release notes label Jul 17, 2024
@shaibagon
Copy link

How come unit tests for ColorJitter passes with numpy>=2.0?
See #8536.

Should there be a greater fix to support numpy 2?

@NicolasHug
Copy link
Member Author

Failures on #8536 are unrelated to this PR. Let me reply there.

facebook-github-bot pushed a commit that referenced this pull request Aug 2, 2024
Reviewed By: vmoens

Differential Revision: D60596243

fbshipit-source-id: 83414c1f05b9a83f5091b85ee51a9cd4493dcbd5
@adamjstewart adamjstewart mentioned this pull request Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed other if you have no clue or if you will manually handle the PR in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants