Skip to content

Conversation

rdong8
Copy link
Contributor

@rdong8 rdong8 commented Aug 27, 2025

  • Fix typo in find_package: WEBP -> WebP
  • Remove AVIF since that has already been moved to torchvision-extra-decoders and is unused here

Copy link

pytorch-bot bot commented Aug 27, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9193

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Unrelated Failures

As of commit 77efed1 with merge base 48b2f9f (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link

meta-cla bot commented Aug 27, 2025

Hi @rdong8!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Copy link

meta-cla bot commented Aug 27, 2025

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla bot added the cla signed label Aug 27, 2025
@scotts
Copy link
Contributor

scotts commented Aug 28, 2025

@rdong8, good catch on both fronts! It does look like your change is what we're supposed to do. See: https://chromium.googlesource.com/webm/libwebp/+/HEAD/doc/building.md

@AntoineSimoulin AntoineSimoulin requested a review from scotts August 28, 2025 15:54
@scotts scotts merged commit ce5b26a into pytorch:main Aug 28, 2025
63 of 69 checks passed
Copy link

Hey @scotts!

You merged this PR, but no labels were added.
The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants