Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Op info test for diag_embed #7378

Closed
qihqi opened this issue Jun 25, 2024 · 2 comments
Closed

Op info test for diag_embed #7378

qihqi opened this issue Jun 25, 2024 · 2 comments
Labels
good first issue Good for newcomers torchxla2

Comments

@qihqi
Copy link
Collaborator

qihqi commented Jun 25, 2024

Fix the Op info test for diag_embed

  1. Find the line 44 of test_ops.py and remove
    diag_embed from skip_list
  2. Run op_info test with pytest test/test_ops.py
  3. Fix the failure.

Please refer to
this guide as guide to fix:

Also refer to these PRs:
@qihqi qihqi added good first issue Good for newcomers torchxla2 labels Jun 25, 2024
@ManfeiBai
Copy link
Collaborator

hi, cc @tqfan28, this github issue would be one of the second issue to try, please feel free to reply this issue, so that we could assign this issue to you

ManfeiBai pushed a commit that referenced this issue Sep 18, 2024
@simonteozw
Implement torch diagflat, and movedim as well as it is also needed as…
b79a46b 
… a helper function (#7378) (#8038)
@ManfeiBai
Copy link
Collaborator

ManfeiBai commented Oct 2, 2024 •
edited
Loading

hi, @tqfan28, this op passed test in #8036, will close this ticket for now

please feel free to try other op like this: #7518

@ManfeiBai ManfeiBai reopened this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers torchxla2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@qihqi @ManfeiBai