Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix view data assign #3411

Merged
merged 3 commits into from
Mar 8, 2022
Merged

Fix view data assign #3411

merged 3 commits into from
Mar 8, 2022

Conversation

JackCaoG
Copy link
Collaborator

@JackCaoG JackCaoG commented Mar 7, 2022

This is to fix #3392. More detail debugging in #3392 (comment)

FYI @ronghanghu

@JackCaoG JackCaoG requested a review from bdhirsh March 7, 2022 22:53
@JackCaoG JackCaoG requested a review from bdhirsh March 8, 2022 00:07
bdhirsh
bdhirsh approved these changes Mar 8, 2022
View reviewed changes
Copy link
Collaborator

@bdhirsh bdhirsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice catch :)

@JackCaoG JackCaoG merged commit 8ffef19 into master Mar 8, 2022
@JackCaoG JackCaoG deleted the fix_view_data_assign branch March 8, 2022 03:24
@ronghanghu
Copy link
Collaborator

I tried out the nightly PyTorch XLA wheel. This is working quite well!

@ronghanghu ronghanghu mentioned this pull request Mar 18, 2022
Merged
7 tasks
@JackCaoG JackCaoG mentioned this pull request Mar 23, 2022
Closed
@hgt312 hgt312 mentioned this pull request Mar 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdhirsh bdhirsh bdhirsh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PyTorch XLA erroneously update t's views when it shouldn't (because t.data isn't in-place modified)
3 participants
@JackCaoG @ronghanghu @bdhirsh