DYNAMO RNG seed update optimization #7884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsy323
approved these changes
Aug 20, 2024
lsy323
approved these changes
Aug 20, 2024
| @@ -54,12 +54,18 @@ def random_op(self, a): | |||
| return torch.randn(5, 5, device=a.device) + a | |||
|
|
|||
| def test_random_op_different_result_each_run(self): | |||
| xm.wait_device_ops() | |||
There was a problem hiding this comment.
Just curious why do we need a barrier only for this test
There was a problem hiding this comment.
it is just to be safe for unit tests, there might be async operations that update the metrics. We want to wait for all async ops to finish and then clear the metrics
yitongh
pushed a commit
to AlibabaPAI/xla
that referenced
this pull request
Oct 11, 2024
yitongh
pushed a commit
to AlibabaPAI/xla
that referenced
this pull request
Dec 11, 2024
yitongh
pushed a commit
to AlibabaPAI/xla
that referenced
this pull request
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RNG seed had 2 forms in torch_xla, a xla tensor and a scalar. In the dynamo bridge case we want the tensor form for the execution but for the seed update we don't want to do
tensor.item()since it will cause atransferFromDevice. We can directly access the scalar form of the rng seed