*_pool*d: improve error handling and error messages.
#9648
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors
{avg,max}_pool{2,3}doperation implementations by improving their error message, and returning a status type value.Key Changes:
tensor_methods::avg_pool_nd{,_backward}returnStatusOr<XLATensorPtr>tensor_methods::max_pool_nd{,_backward}returnStatusOr<std::tuple<XLATensorPtr, XLATensorPtr>>CheckIntListRepeatIfSingleElement(span, n): ifspanis a single-element list, create a new one repeating itntimes. Otherwise return the elements inspan.CheckPoolNdInputHasSize(...): check that the given list has a specific sizeFillAndCheckPoolNdInputs(...): runs the 2 functions above for*_pool*dcommon inputs, i.e.kernel_size,stride, andpaddingExample
Before:
After: