-
Notifications
You must be signed in to change notification settings - Fork 559
Revert XLA backward incompatible breaking change - #9668 - Fixes Issue #9685 #9686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert XLA backward incompatible breaking change - #9668 - Fixes Issue #9685 #9686
Conversation
ysiraichi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, looks good to me.
I have a few minor comments:
- Could you be more specific describing the changes in this PR? e.g.:
- Specify which commit you are reverting
- Say that, even though you are reverting that commit, you are bumping the PyTorch pin
- Let's wait, at least, 1 day for @bhavya01 input.
|
@rajkthakur should this go to r2.9 branch instead? We still want to move to newer openxla for top-of-tree I think. |
|
@rajkthakur Could you rebase this on top of |
|
Yes, I realized I need to rebase. |
|
I need to reset and cherry-pick. |
This reverts commit 11590c1.
5a44e19 to
37a0305
Compare
|
@ysiraichi @bhavya01 @qihqi is the torchax failure a concern? |
|
I'm not sure. But, since it's being pushed to the release branch, I think it's important to get everything right. |
#9668 upgraded OpenXLA: openxla/xla@92f7b59 to openxla/xla@9a9aa0e
which introduced a change 5bba026 related to instructions ID that is backward incompatible and causing neuron to crash - Issue #9685
Changes include