Fix push-docs CI for push events without code changes.
#9689
+8
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
This PR seems to contain many unrelated changes. Can you double check?
@ghpvnist , WDYT? I think you introduced the conditional skip of the doc build.
|
Ah, wait. I was doing some work reviewing another PR. The first commit wasn't supposed to be here! |
ysiraichi
force-pushed
the
ysiraichi/fix-docs-ci-on-no-code-changes-push-events
branch
from
8b402a6 to
134b491
Compare
|
@zhanyong-wan Sorry for the noise with those unrelated changes. |
zhanyong-wan
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the error found in this
push-docsCI run for apushevent onmasterbranch.What happened:
push-docsfailed because it couldn't find thetorch-xla-wheelsartifacttorch-xla-wheelsartifact wasn't uploaded because its upload and the dependent build step are coditioned byinputs.has_code_changes == 'true'Solution:
pushevent, since that's also whenpush-docsrunsNote:
push-docsjob actually needs to install both PyTorch and PyTorch/XLA, otherwise it can't retrieve the docstrings that we rely on to build the documentation.