-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new unpublished METOPC VIS calibration coefficients from Patmos-x #109
Conversation
Talked with Carlos Horn, who is trying to find the source of these coefficients. He believes that the MetopC values stem from an intermin, unpublished PATMOS-X calibration dataset. We also tracked down the source calibration files he was once sent (without remembering who that was). For MetopC, that file says:
The coeficients in that file are identical to the ones in this PR. Except for S0, which we convert from the low and high gain estimates to one single value. |
Hi @oliversus @sfinkens (and @carloshorn) I checked my old emails and I can see that we received two sets of MetOp-C coefficients from Mike Foster (NOAA). The first one was received on 22 Sept 2020 and the second, improved one on 2 Feb 2021. The visible channel coefficients S0, S1 and S2 are different in these two files, while the everything rest seems to be the same. I am pasting them below so that Olli can check which CLARA-A3 version/processing corresponds to which set of coefficients. 22 Sept 2020
2 Feb 2021
|
Yes @abhaydd , those coefficients from the 2nd Feb 2021 are the new ones in this pull request. So now we have a source and a date, nice. Those coefficients have not been published by the PATMOS-X group yet, right? |
I don't think they have officially published them yet. I don't see them at least on their website. |
Carlos and me also had a look there before. I think this discussion is sufficient for the moment to serve traceability. I'd suggest to close this PR now and do the merge. |
Nice research, thanks a lot! Can you please take a look at the failing tests? |
…etopC coefficients
Codecov Report
@@ Coverage Diff @@
## main #109 +/- ##
=======================================
Coverage 72.93% 72.93%
=======================================
Files 32 32
Lines 2830 2830
=======================================
Hits 2064 2064
Misses 766 766
Help us with your feedback. Take ten seconds to tell us how you rate us. |
I updated the hashdigest for this new calibration file, replacing the old version saying "provisional MetopC coefficients". |
Ready to merge, @sfinkens ? |
@oliversus thanks for the update! |
Nice work, thanks a lot @oliversus ! And also thanks @mraspaud for merging :) |
Carlos Horn once provided me with these METOPC calibration coefficients. Unfortunately, I do not know the source of these coefficients. I will try to contact him, unless someone else knows where they might be coming from.
I used these coefficients for release 1 of the PyGAC FDR.