Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for frac data #115

Merged
merged 5 commits into from
Oct 24, 2022
Merged

Add support for frac data #115

merged 5 commits into from
Oct 24, 2022

Conversation

mraspaud
Copy link
Member

This PR adds "FRAC" to the list of supported transfer modes for LAC data.

@mraspaud mraspaud self-assigned this Oct 20, 2022
@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Merging #115 (d615d1f) into main (fe4b883) will increase coverage by 0.92%.
The diff coverage is 100.00%.

❗ Current head d615d1f differs from pull request most recent head 2ecad40. Consider uploading reports for the commit 2ecad40 to get more accurate results

@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
+ Coverage   72.93%   73.85%   +0.92%     
==========================================
  Files          32       30       -2     
  Lines        2830     2689     -141     
==========================================
- Hits         2064     1986      -78     
+ Misses        766      703      -63     
Impacted Files Coverage Δ
pygac/lac_reader.py 94.73% <100.00%> (+15.78%) ⬆️
pygac/reader.py 79.43% <100.00%> (ø)
pygac/tests/test_reader.py 98.31% <100.00%> (+0.04%) ⬆️
pygac/__init__.py
pygac/utils.py

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mraspaud
Copy link
Member Author

@helgaweb any comments?

@helgaweb
Copy link

helgaweb commented Oct 20, 2022

@mraspaud Looks good.
You might want to change the documentation here as well

def _validate_header(cls, header):

@mraspaud
Copy link
Member Author

thanks!

Copy link
Member

@sfinkens sfinkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, now we can read FRAC files!! 🎉

pygac/reader.py Outdated Show resolved Hide resolved
Copy link
Member

@sfinkens sfinkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot for this nice feature!

@sfinkens sfinkens merged commit f4c8fd8 into pytroll:main Oct 24, 2022
@mraspaud mraspaud deleted the feature-frac branch October 24, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants