Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with numpy v1.24 #120

Merged
merged 2 commits into from
Jan 4, 2023

Conversation

avalentino
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Dec 29, 2022

Codecov Report

Merging #120 (30144c4) into main (0c721b1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #120   +/-   ##
=======================================
  Coverage   74.39%   74.39%           
=======================================
  Files          32       32           
  Lines        2882     2882           
=======================================
  Hits         2144     2144           
  Misses        738      738           
Impacted Files Coverage Δ
pygac/pod_reader.py 63.63% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@sfinkens sfinkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for fixing this! What do you think of using np.float64 explicitly? I vaguely remember that on some systems a Python float can be 32 bit.

@avalentino
Copy link
Contributor Author

Thanks a lot for fixing this! What do you think of using np.float64 explicitly? I vaguely remember that on some systems a Python float can be 32 bit.

done

Copy link
Member

@sfinkens sfinkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@sfinkens sfinkens merged commit 748774e into pytroll:main Jan 4, 2023
@avalentino avalentino deleted the feature/numpy-v1.24 branch January 4, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants